Switch to io.netty.handler.codec.http.cookie.Cookie in order to support cookies with duplicate keys #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguerra
requested review from
gavinbunney,
argha-c,
karim-z and
lindseyreynolds
gavinbunney
reviewed
Feb 27, 2024
| map.put(cookie.getName(), existing); | ||
| } | ||
| existing.add(cookie); | ||
| map.computeIfAbsent(cookie.name(), k -> new ArrayList<>(1)).add(cookie); |
| has = true; | ||
| break; | ||
| } | ||
| Cookie cookie = ClientCookieDecoder.STRICT.decode(setCookieValue); |
There was a problem hiding this comment.
Intentional to use STRICT here vs LAX in HttpRequestMessageImpl.java and further down in add/setCookie?
There was a problem hiding this comment.
Yeah, I maintained the strict/lax behavior. By default CookieDecoder.decode() uses strict, but for whatever reason ServerCookieEncoder.encode uses lax
Co-authored-by: Gavin Bunney <409207+gavinbunney@users.noreply.github.com>
gavinbunney
approved these changes
Feb 27, 2024
argha-c
pushed a commit
that referenced
this pull request
Sep 10, 2024
…rt cookies with duplicate keys (#1749) * Switch to newer netty cookie parser * more deprecated usages * bump minor version * Update gradle.properties Co-authored-by: Gavin Bunney <409207+gavinbunney@users.noreply.github.com> --------- Co-authored-by: Gavin Bunney <409207+gavinbunney@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using the deprecated
io.netty.handler.codec.http.CookieandCookieDecoder.decode.CookieDecoderis unable to handle duplicate key names, so I had to switch us to the newer decoder. I'm also bumping to 2.5.0 since I had to make breaking changes to interfaces