Only check filter body buffering if message content still inflight #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinbunney
requested review from
jguerra,
argha-c,
lindseyreynolds and
AlexanderEllis
argha-c
approved these changes
May 28, 2024
jguerra
pushed a commit
that referenced
this pull request
Jun 13, 2024
argha-c
pushed a commit
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only check the specific filter
needsBodyBufferedmethod if the message does not yet have a complete body.This fixes a small perf issue for filters which require processing of the zuul message in their
needsBodyBufferedmethod to be able to skip processing of it entirely if the message is already buffered.