Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Key<T> specialization to SessionContext.containsKey #1844

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

connorworley
Copy link
Contributor

No description provided.

@connorworley connorworley requested a review from argha-c November 4, 2024 03:35
@connorworley connorworley marked this pull request as ready for review November 4, 2024 03:35
@@ -107,4 +105,18 @@ void remove() {
Truth.assertThat(context.get(key)).isNull();
Truth.assertThat(val).isEqualTo("bar");
}

@Test
void containsKey() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a test case for the non-typed version as well (if it doesn't already exist)?

@connorworley connorworley merged commit 4ad1d2f into master Nov 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants