Remove LeastConnsEventLoopChooserFactory #2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguerra
requested review from
AlexanderEllis,
argha-c,
gavinbunney,
lalernehl and
lindseyreynolds
as code owners
gavinbunney
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been curious about LeastConnsEventLoopChooserFactory for awhile (since it sounded cool), but the implementation has a ton of issues so I'm just cleaning it up. I'm kicking the can on dealing with
EventLoopGroupMetricsin the constructor (to avoid breaking changes), but it might be worth removing at some point (and also removing the deprecated constructors)