-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce the domain validation when an application bind to the user domain #6860
Labels
verified
All test cases were verified successfully
Comments
stephdl
added a commit
to NethServer/ns8-core
that referenced
this issue
Feb 26, 2024
Add domain inclusion check in bind-user-domains script NethServer/dev#6860
QA
|
DavidePrincipi
removed
the
testing
Packages are available from testing repositories
label
Feb 26, 2024
@stephdl sorry for coming late at the party, but the error returned by the action should conform to other validation errors, e.g. if realm in domains and provision == 'new-domain':
agent.set_status('validation-failed')
json.dump([{'field':'realm', 'parameter':'realm','value': realm, 'error':'domain_already_exists'}], fp=sys.stdout)
sys.exit(2) |
DavidePrincipi
added
the
testing
Packages are available from testing repositories
label
Feb 28, 2024
In core 2.5.3-dev.5 |
DavidePrincipi
added
verified
All test cases were verified successfully
and removed
testing
Packages are available from testing repositories
labels
Mar 4, 2024
VERIFIED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Proposed solution
The code is working well but we do not verify that the user account domain exists before to bind to it, we must have a stronger behaviour and verify before to bind if the user-account exists
Alternative solutions
let the code as is
Additional context
core 2.5.2
The text was updated successfully, but these errors were encountered: