Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualhost of nextcloud must accept only FQDN #6865

Closed
stephdl opened this issue Feb 27, 2024 · 3 comments
Closed

Virtualhost of nextcloud must accept only FQDN #6865

stephdl opened this issue Feb 27, 2024 · 3 comments
Assignees
Labels
verified All test cases were verified successfully

Comments

@stephdl
Copy link

stephdl commented Feb 27, 2024

Steps to reproduce

  • install nextcloud on NS8
  • configure it with a hostname like foo
  • enable the toggle of lets encrypt
  • no error, everything is fine

Expected behavior

I expect to receive a a lets encrypt certificate for nextcloud

Actual behavior

The certificate won't never happen because they validate the FQDN of the requester before to create it, foo is not a FQDN or a domain name. We should require a FQDN or a domain name

Components

nextcloud:1.1.4

@stephdl stephdl added the bug label Feb 27, 2024
@stephdl stephdl self-assigned this Feb 27, 2024
@stephdl
Copy link
Author

stephdl commented Feb 27, 2024

QA

  • install nextcloud from ghcr.io/nethserver/nextcloud:1.1.5-dev.2
  • configure it with a hostname like foo
  • it must be refused and we should have a validation error
  • configure it with a hostname like !?foo
  • it must be refused and we should have a validation error
  • configure a valid fqdn or domain name
  • it must be accepted

@stephdl stephdl added the testing Packages are available from testing repositories label Feb 27, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in NethServer Feb 27, 2024
@DavidePrincipi DavidePrincipi moved this from 🆕 New to 👀 Testing in NethServer Feb 27, 2024
@nrauso nrauso self-assigned this Feb 28, 2024
@nrauso
Copy link

nrauso commented Feb 28, 2024

tested: VERIFIED
All QA cases are correctly managed.

@nrauso nrauso added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Feb 28, 2024
@stephdl
Copy link
Author

stephdl commented Feb 28, 2024

released as ghcr.io/nethserver/nextcloud:1.1.5

@stephdl stephdl closed this as completed Feb 28, 2024
@github-project-automation github-project-automation bot moved this from 👀 Testing to ✅ Done in NethServer Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified All test cases were verified successfully
Projects
Archived in project
Development

No branches or pull requests

2 participants