Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LE certificate request requires a FQDN #6853

Closed
stephdl opened this issue Feb 20, 2024 · 3 comments
Closed

LE certificate request requires a FQDN #6853

stephdl opened this issue Feb 20, 2024 · 3 comments
Assignees
@stephdl
Labels
verified All test cases were verified successfully

Comments

@stephdl
Copy link

stephdl commented Feb 20, 2024

Steps to reproduce

  • Install on NS8 an account provider
  • Install a mail server
  • Install webtop
  • Configure webtop with a hostname foo
  • request a LE certificate

Expected behavior

I expect to request a Let's encrypt certificate with the hostname foo

Actual behavior

Request a lest encrypt certificate needs several conditions but at least it won't never give with a hostname, it requires a fully qualified domain name as foo.com. The actual validator should block us and require a domain foo.com or a FQDN server.foo.com

Components

we have a lot module or core product impacted, in fact we used to validate with json schema like this

"format": "idn-hostname"
"format": "hostname"

See also

https://mattermost.nethesis.it/nethesis/pl/k95kbw8ft3yf5gdtutwgszg18e

thank @lucagasparini
@stephdl stephdl added the bug label Feb 20, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in NethServer Feb 20, 2024
This was referenced Feb 20, 2024
Merged
Merged
@stephdl stephdl added this to stephdl Feb 20, 2024
@stephdl stephdl moved this to Todo in stephdl Feb 20, 2024
@stephdl
Copy link
Author

stephdl commented Feb 21, 2024 •
edited
Loading

  • ns8-mattermost OK
  • ns8-webtop OK
  • ns8-roundcubemail OK
  • ns8-kickstart No validator in configure-module
  • ns8-nextcloud OK verification in Virtualhost of nextcloud must accept only FQDN #6865
  • ns8-imapsync OK
  • ns8-grafana OK
  • ns8-webserver OK
  • ns8-traefik set-route OK
  • ns8-mail OK
  • ns8-collabora OK
  • ns8-dokuwiki OK
  • ns8-minio OK
  • ns8-ejabberd OK
  • ns8-sogo OK
  • ns8-postgresql OK (released in nethforge)
  • ns8-kickstart-mariadb (merged)
  • ns8-kickstart-postgresql (merged)
  • ...

This was referenced Feb 21, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
stephdl added a commit to stephdl/ns8-kickstart-postgresql that referenced this issue Feb 21, 2024
@stephdl
Merge pull request #1 from stephdl:dev6853
7e44be9 
Update hostname validation and error messages NethServer/dev#6853
This was referenced Feb 21, 2024
Merged
Merged
Merged
Merged
stephdl added a commit to stephdl/ns8-kickstart-postgresql that referenced this issue Feb 21, 2024
@stephdl
Merge pull request #3 from stephdl/dev6853
0c8f8e5 
Update hostname format validation and add new translations NethServer/dev#6853
@DavidePrincipi DavidePrincipi moved this from 🆕 New to 🏗 In progress in NethServer Feb 22, 2024
stephdl added a commit to NethServer/ns8-traefik that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #52 from NethServer/dev6853
583f6e5 
Add pattern validation for virtualhost NethServer/dev#6853
stephdl added a commit to NethServer/ns8-webtop that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #36 from NethServer/dev6853
2312b0b 
Update hostname format validation and error message NethServer/dev#6853
stephdl added a commit to NethServer/ns8-mail that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #88 from NethServer/dev6853
f8fefc2 
Update hostname format in validator-definitions.json NethServer/dev#6853
stephdl added a commit to NethServer/ns8-postgresql that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #8 from NethServer/dev6853
560e179 
Update hostname format validation and add translations for host pattern and host format NethServer/dev#6853
stephdl added a commit to NethServer/ns8-sogo that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #9 from NethServer/dev6853
f497662 
Add hostname validation for 'host' field in validate-input.json NethServer/dev#6853
stephdl added a commit to NethServer/ns8-ejabberd that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #38 from NethServer/dev6853
4f72748 
Update hostname validation and messages NethServer/dev#6853
stephdl added a commit to NethServer/ns8-minio that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #7 from NethServer/dev6853
7178d09 
Update hostname format and error handling NethServer/dev#6853
stephdl added a commit to NethServer/ns8-dokuwiki that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #20 from NethServer/dev6853
d91ccdc 
Update hostname format validation and add host field validation messages NethServer/dev#6853
stephdl added a commit to NethServer/ns8-collabora that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #17 from NethServer/dev6853
752a5e5 
Update hostname format and add validation messages for host pattern and format NethServer/dev#6853
stephdl added a commit to NethServer/ns8-webserver that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #52 from NethServer/dev6853
8ffc8be 
Fix validation pattern for ServerNames in create-vhost and update-vhost NethServer/dev#6853
stephdl added a commit to NethServer/ns8-grafana that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #13 from NethServer/dev6853
b4a90e3 
Update hostname format validation NethServer/dev#6853
stephdl added a commit to NethServer/ns8-imapsync that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #13 from NethServer/dev6853
bb002c7 
Update mail_host format and add pattern validation NethServer/dev#6853
stephdl added a commit to NethServer/ns8-nextcloud that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #84 from NethServer/dev6853
5eb8d23 
Update hostname format validation NethServer/dev#6853
stephdl added a commit to NethServer/ns8-roundcubemail that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #34 from NethServer/dev6853
496cdfc 
Update hostname format and add error messages for invalid host pattern and format NethServer/dev#6853
stephdl added a commit to NethServer/ns8-mattermost that referenced this issue Feb 22, 2024
@stephdl
Merge pull request #67 from NethServer/dev6853
05a52f9 
Add pattern validation for host name in configure-module/validate-input.json NethServer/dev#6853
@stephdl stephdl moved this from Todo to In Progress in stephdl Feb 22, 2024
@stephdl stephdl moved this from In Progress to Done in stephdl Feb 22, 2024
@stephdl stephdl moved this from Done to In Progress in stephdl Feb 22, 2024
@DavidePrincipi DavidePrincipi added the testing Packages are available from testing repositories label Feb 22, 2024
@DavidePrincipi DavidePrincipi moved this from 🏗 In progress to 👀 Testing in NethServer Feb 22, 2024
@DavidePrincipi
Copy link
Member

VERIFIED

The patch was verified for NextCloud
#6865 (comment)

Let's close this issue. We will release individual modules in the upcoming weeks.

@DavidePrincipi DavidePrincipi added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Feb 28, 2024
@stephdl
Copy link
Author

stephdl commented Feb 28, 2024

closed, each module will be tested by the developer itself when a new release will occur

@stephdl stephdl closed this as completed Feb 28, 2024
@github-project-automation github-project-automation bot moved this from 👀 Testing to ✅ Done in NethServer Feb 28, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in stephdl Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephdl stephdl

Labels
verified All test cases were verified successfully
Projects
NethServer
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavidePrincipi @stephdl