Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Samba recycle setting breaks the share list #7154

Closed
DavidePrincipi opened this issue Nov 18, 2024 · 2 comments
Closed

Custom Samba recycle setting breaks the share list #7154

DavidePrincipi opened this issue Nov 18, 2024 · 2 comments
Labels
verified All test cases were verified successfully

Comments

@DavidePrincipi
Copy link
Member

DavidePrincipi commented Nov 18, 2024

If we use ":" in the key value of custom Samba Share configuration, the UI returns an error.

Steps to reproduce

  • Configure Samba Recycle Bin (see this post).
  • Go to UI Samba Share page.

Expected results

The share list is displayed

Actual results

An error is returned. Details:

Traceback (most recent call last):
  File "/home/samba1/.config/actions/list-shares/50list_shares", line 75, in <module>
    ocfg.read_file(hconf.stdout, 'samba-registry-conf')
  File "/usr/lib64/python3.11/configparser.py", line 734, in read_file
    self._read(f, source)
  File "/usr/lib64/python3.11/configparser.py", line 1112, in _read
    raise DuplicateOptionError(sectname, optname,
configparser.DuplicateOptionError: While reading from 'samba-registry-conf' [line  7]: option 'recycle' in section 'testfolder' already exists

See also


Thanks to @mrmarkuz

@DavidePrincipi DavidePrincipi converted this from a draft issue Nov 18, 2024
@DavidePrincipi DavidePrincipi changed the title Bug? Custom Samba recycle setting break shares list Custom Samba recycle setting breaks the share list Nov 18, 2024
@DavidePrincipi DavidePrincipi moved this from New to In progress in NethServer Nov 18, 2024
@DavidePrincipi DavidePrincipi self-assigned this Nov 18, 2024
@DavidePrincipi DavidePrincipi added the verified All test cases were verified successfully label Nov 19, 2024
@DavidePrincipi DavidePrincipi removed their assignment Nov 19, 2024
@nethbot nethbot moved this from In progress to Verified in NethServer Nov 19, 2024
@DavidePrincipi
Copy link
Member Author

VERIFIED

See comment NethServer/ns8-samba#60 (comment)

The fix will be released with #7072

@DavidePrincipi DavidePrincipi added this to the NethServer M8.3 milestone Nov 19, 2024
@DavidePrincipi
Copy link
Member Author

@github-project-automation github-project-automation bot moved this from Verified to Done in NethServer Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified All test cases were verified successfully
Projects
Status: Done
Development

No branches or pull requests

1 participant