Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of custom share configuration #60

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

DavidePrincipi
Copy link
Member

The double-colon ":" char is considered a key/value separator in Python's ConfigParser class default configuration. Some share manual settings require ":" in the key string (e.g. Recycle Bin).

This commit configure the ConfigParser object to expect key/value lines separated by "=" char only.

Refs NethServer/dev#7154

The double-colon ":" char is considered a key/value separator in
Python's ConfigParser class default configuration. Some share manual
settings require ":" in the key string (e.g. Recycle Bin).

This commit configure the ConfigParser object to expect key/value lines
separated by "=" char only.
@DavidePrincipi DavidePrincipi self-assigned this Nov 18, 2024
@DavidePrincipi
Copy link
Member Author

VERIFIED

Change verified by community. Kudos to @mrmarkuz

@DavidePrincipi DavidePrincipi changed the base branch from main to feat-7072 November 19, 2024 11:44
@DavidePrincipi DavidePrincipi merged commit 947fac8 into feat-7072 Nov 19, 2024
1 of 4 checks passed
@DavidePrincipi DavidePrincipi deleted the fix-shareconf-parser branch November 19, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant