Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NethLink: the icon on the traybar is virtually impossible to see if the dark theme is set on Windows #7214

Open
edospadoni opened this issue Dec 16, 2024 · 5 comments
Labels
nethlink The issue is related to NethLink (NethVoice Desktop client) nethvoice Bug or features releted to the NethVoice project verified All test cases were verified successfully
Milestone

Comments

@edospadoni
Copy link
Member

edospadoni commented Dec 16, 2024

Describe the bug
The Nethlink icon on the traybar is virtually impossible to see if the dark theme is set on Windows

To Reproduce
Set the dark theme on Windows

Expected behavior
The icon is changed according to the theme set on Windows: dark if the theme is light, light if the theme is dark.

Actual behavior
The icon always remains dark whether the Windows theme is set to light or dark.

Desktop (please complete the following information):

  • Windows 10 22H2

Additional context
The icon is dark in color, when the dark theme is set in Windows, the toolbar becomes dark and the application icon blends in with the color of the toolbar.

Replaces https://github.com/NethServer/nethlink/issues/43
Thanks to @remez

@edospadoni edospadoni added nethlink The issue is related to NethLink (NethVoice Desktop client) nethvoice Bug or features releted to the NethVoice project labels Dec 16, 2024
@edospadoni edospadoni added this to the NethVoice 1.1 milestone Dec 16, 2024
@edospadoni edospadoni changed the title Nethlink: the icon on the traybar is virtually impossible to see if the dark theme is set on Windows NethLink: the icon on the traybar is virtually impossible to see if the dark theme is set on Windows Dec 16, 2024
@mgarra
Copy link

mgarra commented Dec 16, 2024

Tested with Windows 11 Pro 23H2 and the bug is not reproducible.

Dark Theme:
Image

Light Theme:
Image

@viktec
Copy link

viktec commented Dec 16, 2024

version Windows 11, version 24H2

Dark Theme:
Image

Light Theme:

Image

@mgarra
Copy link

mgarra commented Dec 17, 2024

Tested with Windows 10 Pro 22H2 and the bug is reproducible.

Dark Theme:
Image

Light Theme:
Image

@edospadoni edospadoni moved this from Todo to In Progress in NethVoice Dec 18, 2024
@edospadoni
Copy link
Member Author

Test case:

@edospadoni edospadoni added the testing Packages are available from testing repositories label Dec 18, 2024
@nethbot nethbot moved this from In Progress to Testing in NethVoice Dec 18, 2024
@mgarra
Copy link

mgarra commented Dec 18, 2024

Tested again with Windows 10 Pro 22H2 after update in testing and the bug is not reproducible.
The icon now displays correctly in both light and dark themes.

Dark Theme:
Image

Light Theme:
Image

@edospadoni edospadoni added the verified All test cases were verified successfully label Dec 18, 2024
@github-actions github-actions bot removed the testing Packages are available from testing repositories label Dec 18, 2024
@nethbot nethbot moved this from Testing to Verified in NethVoice Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nethlink The issue is related to NethLink (NethVoice Desktop client) nethvoice Bug or features releted to the NethVoice project verified All test cases were verified successfully
Projects
Status: Verified
Development

No branches or pull requests

3 participants