Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(click2call): added new event to handle physical phones #41

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

therockerline
Copy link
Collaborator

@therockerline therockerline commented Dec 12, 2024

This PR adds the Click2Call feature described in the reference below and fixes:

  • If I set a favorite, I don't see the filled star.
  • If I set the light theme, and then close and reopen, the theme returns to dark (probably not saved in preferences).
  • Presence update error. If I switch between the favorites view and speed dial, the presence updates correctly. Upon returning after closing, it remains gray.
  • Ensure that NethLink does not "force" devices on startup and shutdown. It should maintain the physical device if it's set.
  • Connection management and automatic reconnection to inform the user (missing modal to notify the user when there's no connection).
  • Device pairing list should follow the mockup, showing only "Only NethLink" and the various physical devices.
  • On first startup on Mac, the password for SafeStorage is requested (previously it was only asked for unsigned builds).

Reference: NethServer/dev#7118

Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12302997845.
Commit: fad08eb

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

@edospadoni edospadoni changed the title Click2call feat(click2call): added new event to handle physical phones Dec 12, 2024
Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12315445465.
Commit: af337bd

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12316839636.
Commit: cc5c6ee

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12317360244.
Commit: eaec26f

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12340214566.
Commit: abe30f5

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12340351654.
Commit: e73afe1

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12340353638.
Commit: e73afe1

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12340356619.
Commit: e73afe1

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12340360393.
Commit: e73afe1

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12368709587.
Commit: e62d87a

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12372567242.
Commit: 83e88b8

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12374551013.
Commit: c8ffb94

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12374858117.
Commit: 59f40e2

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12395937352.
Commit: 7a4ad1f

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

Copy link

Automatic builds from https://github.com/NethServer/nethlink/actions/runs/12396063082.
Commit: d062fd1

Name Platform Link
win-app.exe Windows Link
macos-app.dmg MacOS Link
linux-app.AppImage Linux Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants