Improve mwan rule form #333

gsanchietti · 2024-08-06T13:12:18Z

Changes:

clean form after save
mimic firewall rules form for a better user experience

Issue: NethServer/nethsecurity#671

Field values where preserved across multiple edit/add actions

andre8244

If we want to change the default value of source and destination, LGTM

public/i18n/en/translation.json

src/composables/useRuleForm.ts

Ensure the rule form in MWAN mimics the format and layout of the firewall rules form to provide a consistent user experience

fix(mwan): clean form on save

a810764

Field values where preserved across multiple edit/add actions

gsanchietti force-pushed the issue671 branch from 59b5280 to 6218ff8 Compare August 6, 2024 13:21

gsanchietti requested review from andre8244 and Tbaile August 6, 2024 13:23

andre8244 approved these changes Aug 6, 2024

View reviewed changes

public/i18n/en/translation.json Outdated Show resolved Hide resolved

src/composables/useRuleForm.ts Show resolved Hide resolved

fix(mwan): mimic firewall rules form

1819693

Ensure the rule form in MWAN mimics the format and layout of the firewall rules form to provide a consistent user experience

gsanchietti force-pushed the issue671 branch from 6218ff8 to 1819693 Compare August 6, 2024 13:56

Tbaile approved these changes Aug 7, 2024

View reviewed changes

gsanchietti merged commit d6a90ce into main Aug 7, 2024
3 checks passed

gsanchietti deleted the issue671 branch August 7, 2024 07:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve mwan rule form #333

Improve mwan rule form #333

gsanchietti commented Aug 6, 2024

andre8244 left a comment

Improve mwan rule form #333

Improve mwan rule form #333

Conversation

gsanchietti commented Aug 6, 2024

andre8244 left a comment

Choose a reason for hiding this comment