Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openvpn): solved wrong mode when editing client tunnel #357

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix(openvpn): solved wrong mode when editing client tunnel #357

merged 1 commit into from
Sep 10, 2024

Conversation

Tbaile
Copy link
Collaborator

@Tbaile Tbaile commented Sep 10, 2024

@Tbaile Tbaile self-assigned this Sep 10, 2024
@Tbaile Tbaile requested a review from andre8244 September 10, 2024 15:22
gsanchietti
gsanchietti requested changes Sep 10, 2024
View reviewed changes
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old logic is the correct one

@Tbaile
Copy link
Collaborator Author

Tbaile commented Sep 10, 2024

So tun => routed and tap => bridged?

@Tbaile Tbaile force-pushed the openvpn-tunnel-wrong-mode-parse branch from d3fd597 to 0a71689 Compare September 10, 2024 15:28
@gsanchietti
Copy link
Member

So tun => routed and tap => bridged?

Yes.

@Tbaile Tbaile requested a review from gsanchietti September 10, 2024 15:28
andre8244
andre8244 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@andre8244 andre8244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust @gsanchietti 😅

@Tbaile Tbaile merged commit 6ec1700 into main Sep 10, 2024
3 checks passed
@Tbaile Tbaile deleted the openvpn-tunnel-wrong-mode-parse branch September 10, 2024 15:43
@Tbaile Tbaile mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andre8244 andre8244 andre8244 approved these changes

@gsanchietti gsanchietti gsanchietti approved these changes

Assignees

@Tbaile Tbaile

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tbaile @gsanchietti @andre8244