Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(traffic): moving instant traffic to another section #446

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

Tbaile
Copy link
Collaborator

@Tbaile Tbaile commented Nov 26, 2024

Closes: NethServer/nethsecurity#936


Screenshots:
127 0 0 1_5173_
127 0 0 1_5173_ (1)

@Tbaile Tbaile requested a review from andre8244 November 26, 2024 11:32
@Tbaile
Copy link
Collaborator Author

Tbaile commented Nov 26, 2024

Just noticed that Filter section shouldn't be the size of the table. However I feel this is more "correct" way instead of cropping the field to half the size. Asking review to @AmaLuci to get some feedback.

@Tbaile
Copy link
Collaborator Author

Tbaile commented Nov 26, 2024

Also, for @andre8244, the current cap of total host per list is 20, shall we remove the limit?

@Tbaile
Copy link
Collaborator Author

Tbaile commented Nov 26, 2024

Just noticed that Filter section shouldn't be the size of the table. However I feel this is more "correct" way instead of cropping the field to half the size. Asking review to @AmaLuci to get some feedback.

Filters are now fixed max length of max-w-xs as other filter fields.

@andre8244
Copy link
Collaborator

Also, for @andre8244, the current cap of total host per list is 20, shall we remove the limit?

Don't know, you can ask in the team chat if you want

@Tbaile
Copy link
Collaborator Author

Tbaile commented Nov 26, 2024

Why the need to handle loading for each card? Isn't better to put everything behind the skeleton?

@andre8244
Copy link
Collaborator

andre8244 commented Nov 26, 2024

Why the need to handle loading for each card? Isn't better to put everything behind the skeleton?

Ok I missed it. Then you can remove the skeletonLines prop on the cards since it is useless

@Tbaile Tbaile requested a review from andre8244 November 26, 2024 13:53
@Tbaile Tbaile merged commit 6fdd829 into issue-900 Nov 26, 2024
3 checks passed
@Tbaile Tbaile deleted the issue-936 branch November 26, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants