-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add port forward page #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add port forward entry in sidemenu and router - add port forward page - add port forward table list - add create/edit port forward drawer - add fa icons - add related translations
- add new validation functions - add related translations - add validation for fields in the create/edit port forward drawer form - fix port forward table display for multiple items
- create a standalone NeMultiTextInput component - use NeMultiTextInput in pages which used it
- change title in the delete modal - use different lorem ipsum text for placeholder - change primary button label when editing item - use overflow-hidden on NeTable
- move "any" as first option for wan interfaces and dest zones - add device name in description for each wan interface - remove unneeded item
- increase margin below title in NeMultiTextInput - remove commas from translation items - use different gray gradient for disabled items in PortForwardTable - change name of duplicate port forwards
andre8244
requested changes
Oct 4, 2023
src/components/standalone/firewall/CreateOrEditPortForwardDrawer.vue
Outdated
Show resolved
Hide resolved
andre8244
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NeMultiTextInput
component, considering its usage in multiple parts of the application