Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall rules: highlight rules on non-existent zones #899

Closed
gsanchietti opened this issue Nov 12, 2024 · 2 comments
Closed

Firewall rules: highlight rules on non-existent zones #899

gsanchietti opened this issue Nov 12, 2024 · 2 comments
Labels
verified All test cases were verified successfully

Comments

@gsanchietti
Copy link
Member

gsanchietti commented Nov 12, 2024

Currently, firewall rules configured for zones that no longer exist are silently ignored. This can lead to confusion and potential security misconfigurations. To improve user awareness and system management, we might add a visual indicator (such as a warning icon) next to these inactive rules in the firewall rules page.

Other possible improvements:

  • allow the deletion of all zones, including the standard ones
  • alert the user when a zone is deleted and list all rules using the zone

Community discussion: https://community.nethserver.org/t/nethsecurity-suspected-minor-bugs/24471/7?u=andre8244

@stephdl
Copy link
Contributor

stephdl commented Jan 8, 2025

QA
test image
create 3 rules (forward, input, output) in the firewall with a custom zone Foo
the 3 rules are displayed without issue
disable the three rules, you have a disabled badge (state grayed disabled) and a tooltip when you have your mouse over
delete the custom zone
the three rules are displayed with an inactive badge (state grayed disabled) and a tooltip when you have your mouse over
the inactive zone state wins over the disabled state, you can disabled a rule with a deleted zone, you will still have an inactive rulle badge

@stephdl stephdl removed their assignment Jan 8, 2025
@stephdl stephdl added the testing Packages are available from testing repositories label Jan 8, 2025
@nethbot nethbot moved this from In Progress 🛠 to Testing in NethSecurity Jan 8, 2025
@gsanchietti gsanchietti self-assigned this Jan 8, 2025
gsanchietti added a commit to NethServer/nethsecurity-ui that referenced this issue Jan 9, 2025
@gsanchietti
Copy link
Member Author

Verified with image 23.05.5-ns.1.4.1-14-g490620e1f

@gsanchietti gsanchietti added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Jan 9, 2025
@gsanchietti gsanchietti removed their assignment Jan 9, 2025
@nethbot nethbot moved this from Testing to Verified in NethSecurity Jan 9, 2025
@github-project-automation github-project-automation bot moved this from Verified to Done ✅ in NethSecurity Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified All test cases were verified successfully
Projects
Status: Done ✅
Development

No branches or pull requests

4 participants