Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ns-api: add nathelpers api #731

Merged
merged 3 commits into from
Sep 6, 2024
Merged

ns-api: add nathelpers api #731

merged 3 commits into from
Sep 6, 2024

Conversation

andre8244
Copy link
Collaborator

@andre8244 andre8244 self-assigned this Sep 5, 2024
@andre8244 andre8244 force-pushed the nat-helpers-api branch 4 times, most recently from ac9b2fd to 7a63bbd Compare September 6, 2024 10:45
@andre8244 andre8244 marked this pull request as ready for review September 6, 2024 10:59
gsanchietti
gsanchietti requested changes Sep 6, 2024
View reviewed changes
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just fix the ns.nathelpers.json file

packages/ns-api/files/ns.nathelpers.json Outdated Show resolved Hide resolved
andre8244 and others added 2 commits September 6, 2024 13:52
@andre8244 @gsanchietti
Update packages/ns-api/README.md
c6d7969 
Co-authored-by: Giacomo Sanchietti <giacomo.sanchietti@nethesis.it>
@andre8244 @gsanchietti
Update packages/ns-api/files/ns.nathelpers.json
ce2a200 
Co-authored-by: Giacomo Sanchietti <giacomo.sanchietti@nethesis.it>
@gsanchietti gsanchietti merged commit d90b246 into main Sep 6, 2024
1 check passed
@gsanchietti gsanchietti deleted the nat-helpers-api branch September 6, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsanchietti gsanchietti gsanchietti approved these changes

Assignees

@andre8244 andre8244

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andre8244 @gsanchietti