Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ns-api(openwrt): avoiding overwrite of network config #883

Merged
merged 1 commit into from
Nov 4, 2024
Merged

ns-api(openwrt): avoiding overwrite of network config #883

merged 1 commit into from
Nov 4, 2024

Conversation

Tbaile
Copy link
Contributor

@Tbaile Tbaile commented Oct 31, 2024

@Tbaile Tbaile requested a review from gsanchietti October 31, 2024 15:34
gsanchietti
gsanchietti requested changes Nov 4, 2024
View reviewed changes
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the code looks good, it's better to add the same check also on add_client function

@Tbaile
ns-api(openwrt): avoiding overwrite of network config
c5f5650 
Signed-off-by: Tommaso Bailetti <tommaso.bailetti@nethesis.it>
@Tbaile Tbaile requested a review from gsanchietti November 4, 2024 13:01
@Tbaile Tbaile merged commit 4783d9f into main Nov 4, 2024
1 check passed
@Tbaile Tbaile deleted the issue879 branch November 4, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsanchietti gsanchietti gsanchietti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tbaile @gsanchietti