Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding ns-binding package #917

Merged
merged 8 commits into from
Dec 11, 2024
Merged

feat: adding ns-binding package #917

merged 8 commits into from
Dec 11, 2024

Conversation

Tbaile
Copy link
Contributor

@Tbaile Tbaile commented Nov 15, 2024

Introducing IP/MAC binding for DHCP interfaces.

Ref: #918

@Tbaile Tbaile force-pushed the macip-binding branch 8 times, most recently from d966319 to c548ea7 Compare November 18, 2024 15:27
@Tbaile Tbaile changed the title feat: adding ns-binding package (wip) feat: adding ns-binding package Nov 19, 2024
@Tbaile Tbaile requested a review from gsanchietti November 19, 2024 09:58
@Tbaile Tbaile marked this pull request as ready for review November 19, 2024 10:29
packages/ns-binding/Makefile Outdated Show resolved Hide resolved
packages/ns-binding/files/ns-binding.init Outdated Show resolved Hide resolved
packages/ns-binding/files/ns-binding.py Outdated Show resolved Hide resolved
packages/ns-binding/files/ns-binding.py Outdated Show resolved Hide resolved
packages/ns-binding/files/ns-binding.py Outdated Show resolved Hide resolved
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
But before merging, let's wait some more tests on a real scenario.

@gsanchietti gsanchietti self-requested a review December 5, 2024 15:47
@gsanchietti gsanchietti merged commit ac7c627 into main Dec 11, 2024
1 check passed
@gsanchietti gsanchietti deleted the macip-binding branch December 11, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants