Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ns-api): improve dpireport details #958

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix(ns-api): improve dpireport details #958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/ns-api/files/ns.dpireport
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,9 @@ def summary_v2(year=None, month=None, day=None, narrow_client=None, narrow_secti
'traffic': raw_client_total_traffic
})

# do not display empty values when seeing details
if narrow_section and narrow_value:
raw_clients = [client for client in raw_clients if client['traffic'] > 0]
raw_clients.sort(key=lambda x: x['traffic'], reverse=True)
final_clients = raw_clients[:limit]

Expand Down
Loading