Install nethvoice-proxy during nethvoice migration #100
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in
|
stephdl
force-pushed
the
list-modules
branch
from
1ca2634 to
839a17a
Compare
|
in
|
stephdl
force-pushed
the
list-modules
branch
from
839a17a to
2accf0a
Compare
|
in
|
stephdl
changed the title
|
in
|
stephdl
force-pushed
the
list-modules
branch
from
a7d70ac to
be84c20
Compare
|
in
|
There was a problem hiding this comment.
I'm not sure that nethvoice-proxy should be treated like NS7 apps (for example Ejabberd). It is not a NS7 app that has to be migrated to NS8, instead it is a NS8 app requirement for NethVoice. It is just a matter of checking if the destination node has at least a nethvoice-proxy instance.
Please link this PR to an issue, let's ask review to the NethVoice team, too.
root/usr/share/nethesis/nethserver-ns8-migration/apps/nethserver-nethvoice14/bind
Outdated
Show resolved
Hide resolved
root/usr/share/nethesis/nethserver-ns8-migration/apps/nethserver-nethvoice14/bind
Outdated
Show resolved
Hide resolved
|
in
|
stephdl
force-pushed
the
list-modules
branch
from
5b8b61b to
47b8d40
Compare
|
in
|
|
in
|
stephdl
force-pushed
the
list-modules
branch
from
90fefb6 to
a171cb2
Compare
|
in
|
stephdl
force-pushed
the
list-modules
branch
from
a171cb2 to
921f0ee
Compare
|
in
|
stephdl
force-pushed
the
list-modules
branch
from
921f0ee to
cb34319
Compare
|
in
|
root/usr/share/nethesis/nethserver-ns8-migration/apps/nethserver-nethvoice14/bind
Outdated
Show resolved
Hide resolved
Co-authored-by: Davide Principi <davide.principi@nethesis.it>
|
in
|
Amygos
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test if the nethvoice proxy is installed on the node where we migrate nethserver-nethvoice14
Install on the ns8 node only if missing
NethServer/dev#7221