Fix race condition at system boot #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start rootless modules after Redis is fully functional, to avoid connection failures and corrupted data.
If Redis is not fully started, LOKI endpoint cannot be discovered. Also Redis waits for wg0, if the VPN is not UP Promtail cannot reach the Loki on another node to send log records.
gsanchietti
approved these changes
Sep 12, 2023
stephdl
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules and services relying on Redis for configuration discovery race against
redis.serviceat boot time.If local Redis instance hasn't started, or is synchronizing with master a discovery script might fail or write a bad configuration for its service. A manual service restart usually works around the issue.
This PR configures Systemd units so that user sessions (and Promtail) are started after Redis startup is complete. Only the root user is excluded from this rule, so root login works as soon as possible at boot time.
See https://trello.com/c/PaUsBoUn/427-core-p0-bad-config-after-reboot