Fix agent.tasks regression #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change to the Python agent.tasks library introduced a new key pattern for task output, error and exit code. The pattern does not apply to the Redis event channel name. As result since that change, the Redis client of agent.tasks is no longer capable of listening to task progress and falls back to task polling which is much slower.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to the Python agent.tasks library introduced a new key pattern for task output, error and exit code. The pattern does not apply to the Redis event channel name. As result since that change, the Redis client of agent.tasks is no longer capable of listening to task progress and falls back to task polling which is much slower.
This PR reverts the Pubsub channel name to the original value for the Redis client library. Note that a similar issue is not found in the HTTP library because
api-serveruses a different protocol based on the web socket.See https://trello.com/c/b9reQ77C/428-core-p0-slow-api-cli-task-response
Refs #391