Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api. Add force flag to update-module action #469

Merged
merged 2 commits into from
Oct 12, 2023
Merged

api. Add force flag to update-module action #469

merged 2 commits into from
Oct 12, 2023

Conversation

Amygos
Copy link
Member

@Amygos Amygos commented Oct 11, 2023 •
edited
Loading

Force the module update even if the given module_url is already present in the local Podman storage

github-actions bot pushed a commit that referenced this pull request Oct 11, 2023
@nethbot
apidoc@force_update_module #469
0bff2b8
@Amygos Amygos added the testing Start test suite label Oct 11, 2023
@Amygos Amygos requested a review from DavidePrincipi October 11, 2023 12:11
DavidePrincipi
DavidePrincipi approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, please fix also the relevant documentation

@DavidePrincipi
Copy link
Member

You should use agent.run_helper() instead of subprocess.run()

Copy the existing arguments

@DavidePrincipi DavidePrincipi changed the title core. add force flag to udate-module actions core. Add force flag to update-module action Oct 11, 2023
@DavidePrincipi DavidePrincipi changed the title core. Add force flag to update-module action api. Add force flag to update-module action Oct 11, 2023
github-actions bot pushed a commit that referenced this pull request Oct 11, 2023
@nethbot
apidoc@force_update_module #469
52896f1
@Amygos Amygos removed the testing Start test suite label Oct 11, 2023
github-actions bot pushed a commit that referenced this pull request Oct 11, 2023
@nethbot
apidoc@force_update_module #469
34fa7a7
@Amygos Amygos force-pushed the force_update_module branch from 38fcec7 to d3ed666 Compare October 11, 2023 15:22
github-actions bot pushed a commit that referenced this pull request Oct 11, 2023
@nethbot
apidoc@force_update_module #469
3f7c51b
github-actions bot pushed a commit that referenced this pull request Oct 12, 2023
@nethbot
apidoc@force_update_module #469
d3c2905
Amygos added 2 commits October 12, 2023 12:41
@Amygos
core. add force flag to udate-module actions
6e61277 
Force the module update even if the given `module_url` is already
present in the local Podman storage
@Amygos
doc. Add force flag descripton to modules update
00b9442
@Amygos Amygos marked this pull request as ready for review October 12, 2023 10:52
@Amygos Amygos requested a review from DavidePrincipi October 12, 2023 10:52
@Amygos Amygos force-pushed the force_update_module branch from 653e634 to 00b9442 Compare October 12, 2023 10:53
github-actions bot pushed a commit that referenced this pull request Oct 12, 2023
@nethbot
apidoc@force_update_module #469
617a332
@Amygos Amygos merged commit cef7a83 into main Oct 12, 2023
@Amygos Amygos deleted the force_update_module branch October 12, 2023 13:03
@DavidePrincipi DavidePrincipi added this to the 8.0 RC1 milestone Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidePrincipi DavidePrincipi DavidePrincipi approved these changes

Assignees

@Amygos Amygos

Labels
None yet
Projects
None yet
Milestone
8.0 RC1
Development

Successfully merging this pull request may close these issues.
2 participants
@Amygos @DavidePrincipi