Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node and cluster state/ dirs permissions #627

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

DavidePrincipi
Copy link
Member

@DavidePrincipi DavidePrincipi commented May 2, 2024

Ensure state/ dirs are not world-readable as the build process does not correctly set permissions bits.

Refs NethServer/dev#6917

Ensure state/ dirs are now world-readable as the build process does not
correctly set permissions bits.
@DavidePrincipi DavidePrincipi self-assigned this May 2, 2024
@DavidePrincipi DavidePrincipi added the testing Start test suite label May 2, 2024
@DavidePrincipi DavidePrincipi requested a review from Amygos May 3, 2024 07:17
Copy link
Member

@Amygos Amygos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any other non-root user who needs access to read the cluster/node state?

@DavidePrincipi
Copy link
Member Author

No, other modules must not rely on this bug: the state dir is private for each module. The only way to access its information is through APIs.

@DavidePrincipi DavidePrincipi merged commit 85dfbea into main May 3, 2024
8 checks passed
@DavidePrincipi DavidePrincipi deleted the bug-6917 branch May 3, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Start test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants