Validate leader endpoint URL #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The leader endpoint host address must be resolvable. Ensure it is so, before calling join-node.
If the API URL is unreachable, fail fast in the validation phase: - Send a probe HEAD request to a well-known URL to check the connection - Reduce the retries of the probe task, to speed up the existing check
If the ns-wireguard service was already created by a previous join attempt, ignore the creation failure.
andre8244
approved these changes
Jun 25, 2024
gsanchietti
approved these changes
Jun 25, 2024
| sys.exit(2) | ||
|
|
||
| try: | ||
| requests.head(endpoint_url, verify=request['tls_verify'], timeout=8.0) |
There was a problem hiding this comment.
8 seconds are a very long time for an HTTP response, I'd lower it to 5 or less
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail fast if the leader FQDN does not work for any reason.
The most common failure case is a missing DNS record: the URL of the leader is displayed to help to understand the issue.
In some secondary cases, the leader FQDN is good and validation succeedes, however the VPN hostname cannot be resolved, or does not work. For these cases:
ns-wireguardFirewalld service creation error. The service may exist because it was created by a previous join-node attemptRefs NethServer/dev#6958