Cleanup and fixes for the bouncer container implementation #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not attach a terminal, otherwise output can contain terminal sequences.
Avoid installing app executables under the system dirs.
- system-wide cscli wrapper - /etc/crowdsec orphan directory
1. The ExecReload hook is not used. 2. The implementation cannot work because the configuration file is copied in the container only when it is restarted.
Since the journal is not filtered by modules, restart is no longer required.
Systemd units are templates: automatize their expansion on each update, to ease the current upgrade and future ones. Restart both crowdsec and bouncer services.
- Ensure the bouncer do not daemonize itself - Run container with --init to ensure zombies are reaped - Bouncer: systemd unit ignore exit code 1, returned also with SIGTERM - Controller: systemd unit ignore exit code 143 (SIGTERM)
DavidePrincipi
commented
Apr 5, 2024
stephdl
reviewed
Apr 5, 2024
The bouncer "daemonize" option is deprecated
Run an initialization container with TEST_MODE=true, just to generate the initial Crowdsec configuration. Configuration is written inside the ./crowdsec_config directory, which is mounted as a volume.
The unit of the old package-based bouncer must be disabled and the update code triggered even if the service is only stopped.
DavidePrincipi
force-pushed
the
cleanup-6900
branch
from
72dd222 to
00c0691
Compare
The text label refers to the old "Smarthost" name.
stephdl
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cscliSee individual commits for more information.
Refs NethServer/dev#6900