Add DNS server validation check for configure-module

NethServer · Jul 30, 2024 · 544d985 · 544d985
1 parent 5b1197a
commit 544d985
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/imageroot/actions/configure-module/10validate b/imageroot/actions/configure-module/10validate
@@ -13,6 +13,7 @@ import ipaddress
 import json
 import os
 import sys
+import subprocess
 
 import agent
 import network
@@ -63,3 +64,15 @@ if request["dhcp-server"]["enabled"]:
         agent.set_status('validation-failed')
         json.dump([{'field':'dhcp-server.start', 'parameter':'dhcp-server.start','value': request['dhcp-server']['start'], 'error':'must_be_less_than_end'}], fp=sys.stdout)
         sys.exit(2)
+
+if request["dns-server"]["enabled"]:
+    are_dns_bound = network.are_ports_53_bound()
+    try:
+        p = subprocess.run(['systemctl', 'is-active', '-q', os.environ['MODULE_ID']])
+        running = (p.returncode == 0)
+    except:
+        running = False
+    if are_dns_bound and not running:
+        agent.set_status('validation-failed')
+        json.dump([{'field':'dns-server.enabled', 'parameter':'dns-server.enabled', 'value': "dns_port_already_bind", 'error':'dns_port_already_bind'}], fp=sys.stdout)
+        sys.exit(3)