Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression of bugfix 6959 #12

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix regression of bugfix 6959 #12

merged 1 commit into from
Jun 28, 2024

Conversation

DavidePrincipi
Copy link
Member

The 10setup script terminates with a non-zero exit code at module installation time.

The shell AND causes a non-zero exit code if the service is not enabled.

Refs NethServer/dev#6959

The 10setup script terminates with a non-zero exit code at module
installation time.

The shell AND causes a non-zero exit code if the service is not enabled.
@DavidePrincipi DavidePrincipi requested a review from Tbaile June 28, 2024 15:03
@DavidePrincipi DavidePrincipi self-assigned this Jun 28, 2024
Copy link
Collaborator

@Tbaile Tbaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A return 1 broke everything

@DavidePrincipi DavidePrincipi merged commit 36c54b8 into main Jun 28, 2024
1 check passed
@DavidePrincipi DavidePrincipi deleted the bug-6959-regression branch June 28, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants