Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail piler archive first PR #1

Merged
merged 29 commits into from
Oct 6, 2022
Merged

Conversation

stephdl
Copy link
Collaborator

@stephdl stephdl commented Sep 21, 2022

Install and configure mail Piler in NS8

  • First attempt uses NS7 to archive email in piler in NS8

We need to wait after final ns8-mail to make transport route on custom smtp port other than 587 or 25

Piler is waiting email on a TCP 2525

in /etc/postfix/transport we need to do (for example, think to postmap and restart postfix)

piler.example.com smtp:[piler.example.com]:2525

in NS7 use the Recipient Relay menu

image
image

screen shot of the UI
image

image
image
image

image
image

@stephdl stephdl force-pushed the initialWork branch 2 times, most recently from 2be3335 to dab4141 Compare September 23, 2022 15:03
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall implementation is good.
We need just some minor adjustments.

ui/src/views/Settings.vue Outdated Show resolved Hide resolved
ui/public/i18n/language.json Outdated Show resolved Hide resolved
ui/public/metadata.json Outdated Show resolved Hide resolved
imageroot/actions/configure-module/validate-input.json Outdated Show resolved Hide resolved
imageroot/actions/get-configuration/validate-output.json Outdated Show resolved Hide resolved
imageroot/actions/restore-module/06copyenv Outdated Show resolved Hide resolved
imageroot/actions/restore-module/90firewall Outdated Show resolved Hide resolved
ui/public/i18n/language.json Outdated Show resolved Hide resolved
ui/src/views/Settings.vue Outdated Show resolved Hide resolved
ui/public/i18n/language.json Outdated Show resolved Hide resolved
ui/public/i18n/language.json Outdated Show resolved Hide resolved
ui/public/metadata.json Outdated Show resolved Hide resolved
ui/src/views/Settings.vue Outdated Show resolved Hide resolved
ui/src/views/Settings.vue Outdated Show resolved Hide resolved
ui/src/views/Settings.vue Outdated Show resolved Hide resolved
@andre8244
Copy link

andre8244 commented Sep 26, 2022

Another improvement: since Piler has its own webapp, let's add a link to it in Status page. Example: https://github.com/NethServer/ns8-nextcloud/blob/main/ui/src/views/Status.vue#L20-L53

@stephdl stephdl force-pushed the initialWork branch 2 times, most recently from 615b3ae to aeb11fd Compare September 26, 2022 19:52
Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Piler under a FOSS license?

README.md Outdated Show resolved Hide resolved
imageroot/actions/create-module/90firewall Show resolved Hide resolved
imageroot/templates/config-site.php Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@stephdl stephdl force-pushed the initialWork branch 3 times, most recently from 071c71b to 2d5132d Compare September 27, 2022 15:23
Copy link

@andre8244 andre8244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion. Remember to format Settings.vue and Status.vue source code if you haven't already :)

ui/src/views/Status.vue Outdated Show resolved Hide resolved
@stephdl
Copy link
Collaborator Author

stephdl commented Sep 29, 2022

Actually piler is waiting on TCP 2525 the smtp transaction

Copy link

@andre8244 andre8244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI part LGTM

@stephdl
Copy link
Collaborator Author

stephdl commented Oct 6, 2022

We need to stop now the work on piler the time to wait the development work on ns8-mail. The idea is to use the mail module to make the route to piler and to expose only the TCP 25 port on the wild world web.

@stephdl stephdl merged commit 75d6e92 into NethServer:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants