Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the bulk and selective email restoration by smtp #12

Merged
merged 5 commits into from
May 7, 2024

Conversation

stephdl
Copy link
Collaborator

@stephdl stephdl commented May 6, 2024

This pull request updates the environment variable names in the codebase to use "PROVIDER_IP" instead of "IMAP_HOST" for the IMAP host configuration. This change ensures consistency and clarity in the codebase because imap host === smtp host

Allow the auditor to restore by smtp on the IP of VPN without authentication (unencrypted on 25), we have no more imap authentication because we need to make an event during the domain creation/deletion in the mail server and also create a map action with email alias and username.

Note: you can select one email or the bulk restoration, everything is sent by smtp as an email, however the domain must be listed inside the piler UI
image

image

For restoration You have to set the email where to send the emails, the cons is that everything is sent to inbox, with IMAP recovering it seems that piler respects inbox and sent

jsuto/piler#29

refs: NethServer/dev#6895

@stephdl stephdl requested a review from DavidePrincipi May 6, 2024 19:33
@stephdl
Copy link
Collaborator Author

stephdl commented May 6, 2024

Maybe we could use a rate limit by hour https://github.com/jsuto/piler/blob/bf28ea314b127086a5275b121a1fdeb4466c1d3b/config.php.in#L191

@stephdl
Copy link
Collaborator Author

stephdl commented May 6, 2024

however the restore to mailbox try to restore by imap, obviously it does not work with auditor

image

@stephdl stephdl changed the title Allow the bulk restoration for auditor by smtp Allow the bulk and selective email restoration by smtp May 7, 2024
Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a good improvement!

BTW, the event handler has to connect with the local Redis replica.

@stephdl stephdl merged commit 10a4239 into main May 7, 2024
1 check passed
@stephdl stephdl deleted the restoreBySmtp branch May 7, 2024 10:25
@DavidePrincipi DavidePrincipi mentioned this pull request May 15, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants