Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update retention days in piler.conf template #16

Merged
merged 8 commits into from
May 14, 2024
Merged

Conversation

stephdl
Copy link
Collaborator

@stephdl stephdl commented May 13, 2024

This pull request updates the default retention days in the piler.conf template to the value specified in the configuration. This ensures that the correct retention days are used when archiving emails.

NethServer/dev#6895

image
image

@stephdl stephdl force-pushed the sdl-6895-retention branch 2 times, most recently from 445efb5 to a04cc1f Compare May 13, 2024 17:55
@stephdl stephdl force-pushed the sdl-6895-retention branch from a04cc1f to f3c2bed Compare May 13, 2024 18:33
@stephdl stephdl requested a review from DavidePrincipi May 13, 2024 18:38
ui/public/i18n/language.json Outdated Show resolved Hide resolved
@@ -144,6 +144,29 @@
/>
</cv-column>
</cv-row>
<!-- advanced options -->
<cv-accordion ref="accordion" class="maxwidth mg-bottom">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the retention should be always visible: it is the main configuration parameter for a mail archive as it says how many days a message is retained. Let's remove the accordion /cc @andre8244

Copy link

@andre8244 andre8244 May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, no problem for me

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

stephdl and others added 4 commits May 14, 2024 10:16
Co-authored-by: Davide Principi <davide.principi@nethesis.it>
Co-authored-by: Davide Principi <davide.principi@nethesis.it>
Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephdl stephdl requested a review from andre8244 May 14, 2024 09:13
@stephdl stephdl merged commit b148237 into main May 14, 2024
1 check passed
@stephdl stephdl deleted the sdl-6895-retention branch May 14, 2024 09:15
@DavidePrincipi DavidePrincipi mentioned this pull request May 15, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants