generated from NethServer/ns8-kickstart
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline notifications for one-time installation and mail server configuration status #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfiguration status
stephdl
force-pushed
the
sdl-6895-one-server-is-enough
branch
from
May 14, 2024 15:41
d13ed86
to
b08413a
Compare
stephdl
force-pushed
the
sdl-6895-one-server-is-enough
branch
2 times, most recently
from
May 15, 2024 09:21
aa496e5
to
a4b21c3
Compare
stephdl
force-pushed
the
sdl-6895-one-server-is-enough
branch
from
May 15, 2024 09:42
a4b21c3
to
96ef05c
Compare
19 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some UI labels cleanup/rewording
…tips and warnings
Co-authored-by: Davide Principi <davide.principi@nethesis.it>
Co-authored-by: Davide Principi <davide.principi@nethesis.it>
…/ns8-piler into sdl-6895-one-server-is-enough
The period is not used in helper text 🤷
DavidePrincipi
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds inline notifications for one-time installation and mail server configuration status. It also refactors the language.json file to include additional tooltips and warnings. Additionally, the get-configuration function is refactored to include always_bcc information. The relay rule configuration is also refactored to remove the use of another server. Finally, an unused Python script for validating BCC server is removed.
NethServer/dev#6895
once configured you cannot configured again, when you lost the ownership of your archive to the mail server the save button is disabled and you can see which archive gets the ownership