choose a mail_domain for roundcubemail #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephdl
changed the title
gsanchietti
approved these changes
May 29, 2023
There was a problem hiding this comment.
LGTM but I'd prefer to wait @DavidePrincipi approval before merge.
|
just to add some information in a thread of mattermost relevant to this topic https://mattermost.nethesis.it/nethserver/pl/yt84wwn78fryxb4dqdjcum3mhe |
andre8244
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
I agree with @DavidePrincipi observations. Then let's change the UI label "Mail server" -> "Mail domain" as he suggested. The rest LGTM
Co-authored-by: Davide Principi <davide.principi@nethesis.it>
|
@DavidePrincipi could you approve or ask more to do ? |
DavidePrincipi
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
roundcubemail is sensible to identity, inside mysql user@domain.org != user@domain.com
If you change the domain of users it is a new users with new addressbooks or settings. Previously we forced the mail_domain from a discovery that was wrong, based on the ldap user_domain
we list the mail domain available with addusers=true and we populate the dropbox with them
see comment of davidep #23 (review)