Autodiscover user domain and set environment variable #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephdl
force-pushed
the
sdl-7103
branch
2 times, most recently
from
2390b1e to
f2cdcc7
Compare
9 tasks
gsanchietti
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Main points:
- do not add new env variable: it's not set on existing installation, so the event will be ignored
- ignore node_id parameter
- the module should also listen to
module-domain-changed: the service must be restarted if our mail server is inside themodulesevent parameter
stephdl
force-pushed
the
sdl-7103
branch
2 times, most recently
from
aed978c to
d95d873
Compare
gsanchietti
reviewed
Nov 22, 2024
This is not needed because the mail server publishes the |
gsanchietti
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement autodiscovery of the user domain upon changes and bind it to the environment variable
USER_DOMAIN. This ensures the application responds correctly to user domain updates.NethServer/dev#7103