Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare md5 of public keys for certificate validation #60

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

stephdl
Copy link
Contributor

@stephdl stephdl commented May 29, 2024

This pull request adds a new feature to compare the md5 of public keys for certificate validation. Previously, the certificate and key were compared using their md5 hashes, but now we compare the md5 hashes of their public keys instead.

This is needed because we cannot use the modulus with dsa and ec certificates : see NethServer/dev#6937 (comment)

NethServer/dev#6937

@stephdl stephdl requested a review from Tbaile May 29, 2024 12:48
@stephdl stephdl merged commit 44b482f into main May 30, 2024
1 check passed
@stephdl stephdl deleted the sdl-6937-fix branch May 30, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants