fix(ldap-discovery): use mail domain for user auth #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like it in NS7, the user should use the mail domain for authentication. Example: - mail domain: nethserver.org - user domain associated to mail server: ad.nethserver.org The user should be able to authenticate using user@nethserver.org
stephdl
approved these changes
Dec 4, 2024
DavidePrincipi
approved these changes
Dec 4, 2024
Amygos
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like it in NS7, the user should use the mail domain for authentication. Example:
The user should be able to authenticate using user@nethserver.org
This is a regression for NethServer/dev#7182 caused by PR #96.
Before the regression, the LDAP configuration was correct when done inside the configure-module at this line, but was already wrong when executed on change of the associated mail server implemented in this line.
So the wrong code was reported inside ldap-discovery.
In the end, the ldap-discovery code must always use the mail domain for the configuration and not the user domain.