fix(users): force user name to lower case #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users inside a remote LDAP are usually matched in case-insentive mode. Make sure to always force the username to lower case to avoid mismatch when the remote LDAP has names in uppercase (like AD): this change will fix access for OpenVPN users using the external LDAP. Note that such users are already imported in lower case inside the users db.
Tbaile
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users inside a remote LDAP are usually matched in case-insensitive mode.
Make sure to always force the username to lower case to avoid mismatch when the remote LDAP has names in uppercase (like AD): this change will fix access for OpenVPN users using the external LDAP.
Note that such users are already imported in lower case inside the users db.
NethServer/nethsecurity#966