Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n]zh-cn minor fix #146

Merged
merged 3 commits into from
Dec 10, 2023
Merged

Conversation

cryptonerdcn
Copy link
Contributor

Issue(s):

Description

Fix typos.

Checklist

  • CI Verifier: Run cairo_programs_verifier successfully
  • Contract Tests: Added tests to cover the changes
  • Remix Link: Added a link to open the contract in Remix
  • Deployed Contract (Optional): If possible, include a Voyager link to a deployed contract on Goerli

@julio4
Copy link
Member

julio4 commented Dec 7, 2023

@cryptonerdcn Can you rebase on top of main and check locally if everything is working? I made some refactoring of the overall book structure and it may have broken some parts of the translation.

@cryptonerdcn
Copy link
Contributor Author

@julio4 Yes it breaks sths but not too many. Most of them are links.
I will rebase and fix it.

@cryptonerdcn
Copy link
Contributor Author

@julio4 Finished. We will translate the components chapter next week(because I am translating the components chapter of Cairo Book :p)

@Nadai2010
Copy link
Contributor

Nadai2010 commented Dec 8, 2023

Hello @cryptonerdcn I have a question, when I clone the main repo with the update version locally and run the Spanish version locally, all translation looks fine, but I see that on the book's website they are broken...

Why could that be? Could it be the messages.pot? Or could it be for another reason?

@cryptonerdcn
Copy link
Contributor Author

@Nadai2010 Oh bro sorry I am late.
I think the problem is caused by mdbook(or i18n helpers).
I don't know when it changed but now you must use the specific version, in a specific OS Ubuntu
22.04.3 LTS
, to generate the correct .pot and .po files.
Even the same version of mdbook&i18n-helpers will not work in the same way on other OSs(I have tested Windows 11 and Mac Sonoma).
Now I run a VM with Ubuntu 22.04.3 on my Mac to generate the .pot and .po files.
@julio4 Maybe we can find a way to generate it for translators. Such as using the action to upload it to github.io?

@julio4
Copy link
Member

julio4 commented Dec 9, 2023

Did you encounter the same errors in the Cairo book? I can try to downgrade mdbook to 0.4.31.
I'll need to read the i18n documentation. Feel free to open an issue and continue the discussion there.

@cryptonerdcn
Copy link
Contributor Author

@julio4 Yes, also in Cairo Book, dojobook and starknetbook. They all have same issue now.

@cryptonerdcn
Copy link
Contributor Author

@julio4 Maybe we can merge this first.

@julio4 julio4 merged commit ae353e6 into NethermindEth:main Dec 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants