Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubsub discovery #105

Merged
merged 26 commits into from
Oct 24, 2024
Merged

Pubsub discovery #105

merged 26 commits into from
Oct 24, 2024

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Sep 17, 2024

Testing:

  • Add new test muxer that allows to spawn peers without relying on real network connectivity
  • Add tests to confirm pubsub peer discovery works and messages propagate

Copy link
Contributor

@Marchhill Marchhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with libp2p stuff, mostly just commented on some minor code quality stuff. Pubsub discovery seems to be working well in Shutter testing though

src/libp2p/Libp2p.Core/Discovery/PeerStore.cs Show resolved Hide resolved
src/libp2p/Libp2p.Core/Discovery/PeerStore.cs Outdated Show resolved Hide resolved
src/libp2p/Libp2p.Core/Discovery/PeerStore.cs Show resolved Hide resolved
src/libp2p/Libp2p.Protocols.IpTcp/IpTcpProtocol.cs Outdated Show resolved Hide resolved
src/libp2p/Libp2p.Protocols.Pubsub/PubsubRouter.Topics.cs Outdated Show resolved Hide resolved
src/libp2p/Libp2p.Protocols.Pubsub/PubsubRouter.Topics.cs Outdated Show resolved Hide resolved
src/libp2p/Libp2p.Protocols.Pubsub/PubsubRouter.cs Outdated Show resolved Hide resolved
@flcl42 flcl42 merged commit c2e1e09 into main Oct 24, 2024
4 checks passed
@flcl42 flcl42 deleted the pubsub-discovery branch October 24, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants