Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#63 - Adding Nullable checks #74

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Issue#63 - Adding Nullable checks #74

wants to merge 4 commits into from

Conversation

ssonthal
Copy link

@ssonthal ssonthal commented Feb 23, 2024 •
edited
Loading

Screenshot 2024-02-23 at 11 04 28 AM

@ssonthal ssonthal requested review from flcl42 and rubo as code owners February 23, 2024 05:32
@ssonthal ssonthal mentioned this pull request Feb 23, 2024
Open
@ssonthal
Copy link
Author

Hi @rubo @flcl42 kindly review the PR for resolving the build warnings for nullable references.

flcl42
flcl42 reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@flcl42 flcl42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check the entire solution if possible? dotnet build .\src\libp2p\Libp2p.sln reports more issues

@ssonthal
Copy link
Author

Hey @flcl42, for the solution level, I was previously getting 60 warnings. I have reduced them down to 25 now. But now, I am not sure about the null checks because they are causing some other issues when adding nullables there.

@ssonthal ssonthal requested a review from flcl42 February 23, 2024 19:19
@flcl42
Copy link
Contributor

flcl42 commented Feb 26, 2024

Hey @flcl42, for the solution level, I was previously getting 60 warnings. I have reduced them down to 25 now. But now, I am not sure about the null checks because they are causing some other issues when adding nullables there.

You can propose solution and let me help you with comments

flcl42
flcl42 reviewed Feb 26, 2024
View reviewed changes
src/libp2p/Libp2p.Core/ChannelFactory.cs
}
if (!channel.IsClosed)
if (channel != null && !channel.IsClosed)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

channel is not nullable, so you can omit this check

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flcl42 flcl42 flcl42 left review comments

@rubo rubo Awaiting requested review from rubo rubo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssonthal @flcl42