Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic ping handling and invocation #76

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Add basic ping handling and invocation #76

merged 1 commit into from
Apr 15, 2024

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Apr 1, 2024

  • Fix IoC bug;
  • Add ping to keep connections alive

@flcl42 flcl42 requested a review from rubo as a code owner April 1, 2024 15:54
rubo
rubo approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@rubo rubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it tested?

@flcl42 flcl42 merged commit 0e839d0 into main Apr 15, 2024
2 checks passed
@flcl42 flcl42 deleted the feature/yamux-ping-poc branch April 15, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubo rubo rubo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flcl42 @rubo