Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapsync with p2p #2120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Snapsync with p2p #2120

wants to merge 1 commit into from

Conversation

pnowosie
Copy link
Contributor

@pnowosie pnowosie commented Sep 5, 2024

Going on with #2035

@pnowosie pnowosie force-pushed the pnowosie/snap-sync-p2p branch 2 times, most recently from 330edcc to 3564bf0 Compare September 17, 2024 09:33
@pnowosie pnowosie force-pushed the pnowosie/snap-sync-p2p branch 4 times, most recently from c384cda to e3c0e8c Compare September 30, 2024 19:08
@pnowosie pnowosie marked this pull request as ready for review October 2, 2024 10:03
@stranger80 stranger80 mentioned this pull request Oct 7, 2024
16 tasks
Makefile Outdated
@@ -110,12 +110,14 @@ feedernode: juno-cached
./build/juno \
--network=sepolia \
--log-level=debug \
--db-path=./p2p-dbs/feedernode \
--db-path="/Users/pnowosie/juno/snapshots/juno-sepolia" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert it? :)

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 37.22504% with 371 lines in your changes missing coverage. Please review.

Project coverage is 73.37%. Comparing base (7286fe7) to head (f99c07f).

Files with missing lines Patch % Lines
core/state.go 4.06% 187 Missing and 2 partials ⚠️
blockchain/snap_server_interface.go 4.47% 63 Missing and 1 partial ⚠️
core/trie/snap_support.go 74.49% 26 Missing and 12 partials ⚠️
blockchain/blockchain.go 34.09% 29 Missing ⚠️
core/contract.go 0.00% 17 Missing ⚠️
core/trie/trie.go 62.85% 10 Missing and 3 partials ⚠️
db/pebble/db.go 0.00% 8 Missing ⚠️
core/trie/proof.go 0.00% 6 Missing ⚠️
node/node.go 44.44% 4 Missing and 1 partial ⚠️
db/remote/db.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2120      +/-   ##
==========================================
- Coverage   75.16%   73.37%   -1.79%     
==========================================
  Files         107      109       +2     
  Lines       11392    11972     +580     
==========================================
+ Hits         8563     8785     +222     
- Misses       2175     2520     +345     
- Partials      654      667      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

**This is a squash batch of 23 commits:**

- Ashraf Basic snap algo .. Did something + #1925
- p2p client and looking at the syncService
- finishing p2p handler - question
- protobuf changes
- snap server implements handler methods directly
- fix snap server tests after refactor
- refactor syncer to loop over iterator, add client message handling
- p2p complete - no data exchange
- Managed to sync ~200MB data
- Fix: Trie iteration
- test describing how storage of big contracts are responded
- Storage ranges - fix unexpected contract change
- Tweak message size params, trim logs
- limit memory usage & verification
- verification bug fix
- Add sync mode p2p CLI flag (#2186)
- Return struct instead of interface
- Change flag usage string
- Remove SnapServer interface
- Revert makefile
- Minor fixes
- Update docs
- Less logs, verification fixed
- code improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants