Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecondsPerSlot in eth_estimateGas #6037

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

MarekM25
Copy link
Contributor

Changes

In estimateGas we can use Timestamp opcode. The better estimates we will get once timestamp opcode will give us currentBlock.Timestamp + SecondsPerSlot.

Requires unit tests and testing. Draft to open discussion.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

In progress.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@smartprogrammer93 smartprogrammer93 merged commit 2289308 into master Aug 25, 2023
61 checks passed
@smartprogrammer93 smartprogrammer93 deleted the estimateGas_basedOnSlotTime branch August 25, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants