Perf/read rpc message to end #6951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
requested review from
benaadams,
asdacap,
MarekM25,
marcindsobczak and
kamilchodola
LukaszRozmej
commented
Apr 26, 2024
Comment on lines
140
to
142
| ReadResult readResult = _jsonRpcConfig.MaxRequestBodySize is not null | ||
| ? await reader.ReadAtLeastAsync((int)_jsonRpcConfig.MaxRequestBodySize.Value) | ||
| : await reader.ReadToEndAsync(); |
There was a problem hiding this comment.
I'm torn about this one, @benaadams ?
There was a problem hiding this comment.
Am wondering about adding a timeout also?
There was a problem hiding this comment.
vs a very slow request; like if the full request takes more than 1sec to receive chop it?
There was a problem hiding this comment.
We have some global timeouts on json rpc
There was a problem hiding this comment.
Will think about it a bit more.
benaadams
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Would be worth comparing performance on very many batched requests (as many as you can under 30MB request limit) as it might be better or worse than original.
@marcindsobczak Would be worth comparing NewPayload performance with big but reasonable size blocks.
Documentation
Requires documentation update
Requires explanation in Release Notes