Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce space use spike after sync #7138

Merged
merged 14 commits into from
Jun 6, 2024
Merged

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jun 5, 2024

  • Reduce aggressiveness of HeavyWrite tune. Reduce target l0 size from 4GB to 2Gb.
  • Set max compaction size to 4GB.
  • Set kOldestLargestSeqFirst compaction priority for db that uses block number. This significantly reduce write amp.
  • Add CompressibilityHint param to account for suprisingly large difference in memtable and sst size. This reduce write amp on first level due to different in size between l0 and l1.

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Looks fine.

@asdacap asdacap marked this pull request as ready for review June 6, 2024 00:00
@asdacap asdacap requested a review from rubo as a code owner June 6, 2024 00:00
@asdacap asdacap merged commit 0d700b3 into master Jun 6, 2024
68 checks passed
@asdacap asdacap deleted the fix/column-not-using-config branch June 6, 2024 11:04
kamilchodola pushed a commit that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants