-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to lower contention ClockCache #7215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall well done, but can we remove code duplication, by extracting a shared component that would do the access tracking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Clock bit operations is pretty similar to the BitFilter
in Paprika
😅
The clock is simple and easy to reason about.
I believe we can make atomics simpler. Provided comments.
src/Nethermind/Nethermind.Core/Caching/ClockKeyCacheNonConcurrent.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/Caching/ClockKeyCacheNonConcurrent.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?