Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC Tx lookup changes #7282

Merged
merged 1 commit into from
Jul 23, 2024
Merged

RPC Tx lookup changes #7282

merged 1 commit into from
Jul 23, 2024

Conversation

LukaszRozmej
Copy link
Member

@LukaszRozmej LukaszRozmej commented Jul 23, 2024 •
edited
Loading

Mitigates #7251

This resolves the issue, but doesn't fix the root cause of #7251

Changes

  • Changes order of tx lookup to look first into canonical chain before looking in tx pool

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@LukaszRozmej LukaszRozmej merged commit 54f5817 into master Jul 23, 2024
68 checks passed
@LukaszRozmej LukaszRozmej deleted the fix/eth_gettransaction branch July 23, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcindsobczak marcindsobczak marcindsobczak approved these changes

@flcl42 flcl42 Awaiting requested review from flcl42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukaszRozmej @marcindsobczak