Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing totalDifficulty field from BlockForRpc class while returning… #7434

Closed
wants to merge 4 commits into from
Closed

Removing totalDifficulty field from BlockForRpc class while returning… #7434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d68150e
Removing totalDifficulty field from BlockForRpc class while returning…
ssonthal Sep 15, 2024
b547872
Removing "totalDifficulty" fields from output responses of RPC Module…
ssonthal Sep 15, 2024
2469b01
Merge branch 'master' into 7397_removing_total_difficulty_from_block_…
ssonthal Sep 16, 2024
5fa7204
Merge branch 'master' into 7397_removing_total_difficulty_from_block_…
ssonthal Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Nethermind/Nethermind.Facade/Eth/BlockForRpc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ public BlockForRpc(Block block, bool includeFullTransactionData, ISpecProvider s
Size = _blockDecoder.GetLength(block, RlpBehaviors.None);
StateRoot = block.StateRoot;
Timestamp = block.Timestamp;
TotalDifficulty = block.TotalDifficulty ?? 0;
Transactions = includeFullTransactionData ? block.Transactions.Select((t, idx) => new TransactionForRpc(block.Hash, block.Number, idx, t, block.BaseFeePerGas)).ToArray() : block.Transactions.Select(t => t.Hash).OfType<object>().ToArray();
TransactionsRoot = block.TxRoot;
Uncles = block.Uncles.Select(o => o.Hash);
Expand Down Expand Up @@ -118,7 +117,6 @@ public BlockForRpc(Block block, bool includeFullTransactionData, ISpecProvider s
[JsonConverter(typeof(NullableRawLongConverter))]
public long? Step { get; set; }
public bool ShouldSerializeStep() => _isAuRaBlock;
public UInt256 TotalDifficulty { get; set; }
public UInt256 Timestamp { get; set; }

public UInt256? BaseFeePerGas { get; set; }
Expand Down
Loading