Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non-allocating split #7837

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Use non-allocating split #7837

merged 3 commits into from
Nov 29, 2024

Conversation

benaadams
Copy link
Member

Contributes to #7361

Changes

  • Use non allocating span.Split rather than string.Split

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams requested a review from asdacap November 29, 2024 06:25
@benaadams benaadams merged commit 89c5835 into master Nov 29, 2024
79 checks passed
@benaadams benaadams deleted the non-allocating-split branch November 29, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekM25 MarekM25 MarekM25 approved these changes

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

@asdacap asdacap Awaiting requested review from asdacap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @MarekM25